Skip to content

add async score function to TrustworthyRAG module #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 12, 2025
Merged

Conversation

axl1313
Copy link
Contributor

@axl1313 axl1313 commented Apr 12, 2025

What changed?

Adds an async version of score function to TrustworthyRAG. This is needed for integrating Codex as Backup into Agility. Otherwise we get an error that the event loop is already running when calling self._event_loop.run_until_complete()

What do you want the reviewer(s) to focus on?


Checklist

  • Did you link the GitHub issue?
  • Did you follow deployment steps or bump the version if needed?
  • Did you add/update tests?
  • What QA did you do?
    • Tested...

Copy link
Contributor

@jas2600 jas2600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one suggestion for the docstring otherwise LGTM. Don't forget to upgrade the version and release

@jas2600
Copy link
Contributor

jas2600 commented Apr 12, 2025

@axl1313 also need to add this new method to https://github.com/cleanlab/cleanlab-studio-docs/blob/main/scripts/config/api_reference_config.yaml#L52 since we have customized method order for doc generation

Co-authored-by: Jay Zhang <jas2600@gmail.com>
@axl1313
Copy link
Contributor Author

axl1313 commented Apr 12, 2025

@axl1313 also need to add this new method to https://github.com/cleanlab/cleanlab-studio-docs/blob/main/scripts/config/api_reference_config.yaml#L52 since we have customized method order for doc generation

@jas2600 is it okay to update that before this change is released?

@jas2600
Copy link
Contributor

jas2600 commented Apr 12, 2025

@axl1313 also need to add this new method to https://github.com/cleanlab/cleanlab-studio-docs/blob/main/scripts/config/api_reference_config.yaml#L52 since we have customized method order for doc generation

@jas2600 is it okay to update that before this change is released?

yes it should be fine. it will just ignore if there is no method matched https://github.com/cleanlab/cleanlab-studio-docs/blob/main/scripts/fix_generated_api_docs.py#L198

@axl1313 axl1313 merged commit 6b041bd into main Apr 12, 2025
3 checks passed
@axl1313 axl1313 deleted the async-rag branch April 12, 2025 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants