Skip to content

Default threshold to zero #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 16, 2025
Merged

Default threshold to zero #75

merged 4 commits into from
Apr 16, 2025

Conversation

elisno
Copy link
Member

@elisno elisno commented Apr 16, 2025

Key Info

  • Implementation plan: link
  • Priority: low

What changed?

Default thresholds for arbitrary evals runs by TrustworthyRAG are now set to 0.

It means an eval other than trustworthiness and response_helpfulness (at the time of this writing) will not influence the value of is_bad_response when running Validator.validate(). A user must provide their own threshold for their user-defined evals.

@elisno elisno requested review from jwmueller and ulya-tkch and removed request for jwmueller April 16, 2025 17:01
Copy link
Contributor

@ulya-tkch ulya-tkch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Ulyana <ulya.tkach@gmail.com>
@elisno elisno merged commit e57fd31 into main Apr 16, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants