get_allure_attachment_type_from_content_type can return None

[Slaaayer]

Some generated attachments remain with their default .attach extension and therefore generate the following warning:

WARNING: Unsupported extension: attach (file:/ed91ab39fb32bf08.attach)

This is due to the fact of not having any fallback mechanism in get_allure_attachment_type_from_content_type in case the content type wasn't found.

[cle-b]

Hello,

Can you give me a repro case to help me reproduce this warning, please? Where are you seeing it?

When I test with a payload that has an unknown type, the report shows a download link and the browser downloads the content of the request without trying to render it. What do you expect to happen if the content type is unknown to Allure? Is your main complaint about the “.attach” extension being added, or about the fact that we don’t recognize the content type?

I can try to fix your issue, but I need more information to understand what you expect.

[Slaaayer]

Can you give me a repro case to help me reproduce this warning, please? Where are you seeing it?

Here is a use case to reproduce this warning

import threading
from http.server import BaseHTTPRequestHandler, HTTPServer

import requests


class MockHandler(BaseHTTPRequestHandler):
    def do_GET(self):
        if self.path == "/toto":
            self.send_response(200)
            self.send_header("Content-Type", "application/json;charset=utf-8,application/json;charset=utf-8")
            self.end_headers()
            self.wfile.write(b'{"id": 123, "name": "Mock User"}')
        else:
            self.send_response(404)
            self.end_headers()


def run_server(server):
    with server:
        server.serve_forever()


def test_repro():
    server = HTTPServer(("localhost", 8081), MockHandler)
    thread = threading.Thread(target=run_server, args=(server,), daemon=True)
    thread.start()

    url = "http://localhost:8081/toto"
    requests.get(url)

    server.shutdown()

When doing an allure-combine command, I get that warning.

Is your main complaint about the “.attach” extension being added, or that we don’t recognize the content type?

My main complaint is about that warning flooding my logs ^^'. I would expect that httpdbg has some fallback mechanism if the content-type isn't found in allure.attachment_type in:

def get_allure_attachment_type_from_content_type(content_type: str):
    try:
        import allure

        for attachment_type in allure.attachment_type:
            if attachment_type.mime_type == content_type:
                return attachment_type
    except ImportError:
        pass
    return None

So that when req_resp_steps is called, the allure.attach from this segment isn't called with attachment_type=None :

if payload:
      attachment_type = get_allure_attachment_type_from_content_type(
          content.get("content_type")
      )
      allure.attach(
          payload, name="payload", attachment_type=attachment_type
      )

In this case, the payload isn't logged properly in the allure report:

I hope it's more explicit, feel free to reach out if I can provide further information.

I can try and suggest a fix if that is suitable

[cle-b]

Thanks for the repro case. That’s clearer now. :)

I haven’t been able to reproduce the warning during the generation of the Allure report. I use the Docker image frankescobar/allure-docker-service to generate the report, which is probably why I don’t see the same behavior.

I haven’t found a default attachment type that works in all cases (both text and binary payloads).

To try to fix your issue, I improved the function that detects the attachment type based on the content type. It should at least fix the case from your repro example.

You can test the fix in pytest-httpdbg v0.9.1.

Let me know if that resolves your issue.

[Slaaayer]

Thanks for the fix, this works fine for me.

On a separate note, I have another question. I’ve noticed that the parameters --httpdbg and --httpdbg-allure are mutually exclusive. Is there a way to include the httpdbg logs in both the Allure reports and the *.md files?

[cle-b]

On a separate note, I have another question. I’ve noticed that the parameters --httpdbg and --httpdbg-allure are mutually exclusive. Is there a way to include the httpdbg logs in both the Allure reports and the *.md files?

No, there is no way to do that with the current version of pytest-httpdbg. Please open another issue if you want it for a future version. I think it should be doable.

Thanks for the fix, this works fine for me.

Good to know the fix has solved your issue. I'm closing this issue.