Remove unused/undocumented component.onModelChange#41
Open
tsjoberg wants to merge 1 commit intoclayallsopp:masterfrom
Open
Remove unused/undocumented component.onModelChange#41tsjoberg wants to merge 1 commit intoclayallsopp:masterfrom
tsjoberg wants to merge 1 commit intoclayallsopp:masterfrom
Conversation
Contributor
Author
|
@markijbema @clayallsopp not sure what you envision for deprecation warning |
Contributor
Author
|
Fixes #40 |
Collaborator
|
Yes, I think that would be best, and then remove it in a version a few months later. I'm not sure what react itself uses, but it seems to have some deprecation warning messaging, maybe you could plug into that? Problem with just removing is that if somebody uses it, it may fail very subtly. For instance if you do increment of a counter, and then forceUpdate, the counter won't update, but everything seems to work, so this might silently introduce bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.