Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing deleting temp files and incorrect zip file #318

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

vincenzoAiello
Copy link
Contributor

This could fix the issue with the incorrect zip files (#317) and the delete of the temporary zip files in Windows (#277).

To fix the incorrect zip compression i reuse the archivex library (like it was done at the beginning) but for fixing the delete of the temporary zip files in Windows, i use the "CreateWriter" function in order to close, at the end of function, the writer and the file.

@claudiodangelis
Copy link
Owner

Thanks for this!
Are you able to reproduce the original zip issue on Windows?

@vincenzoAiello
Copy link
Contributor Author

Yes,sure.
If we use the compression method without library and we send a directory like this

esempioDir
the zip file received on the phone through qrcp, will be incorrect
photo_2023-12-20_18-00-49

With the new method the zip file will be correct

photo_2023-12-20_17-54-26
photo_2023-12-20_17-54-26 (2)
photo_2023-12-20_17-54-26 (3)

If we send the same zip file on windows though qrcp, it will appear correctly.

zip1
zip2
zip3

During the sending, the temporary files error, will not be present beacause the file is closed successfully

image

@claudiodangelis
Copy link
Owner

Perfect, and are you able to reproduce the issue with 0.10.1 where the tool panics after sending the zip?
If so, can you confirm the issue is gone with your new patch?
If everything is working, we can release 0.11.1 tomorrow.
Thanks!
C

@vincenzoAiello
Copy link
Contributor Author

Yes, in the 0.10.1 version when i try to send a file and It Is received, It shows an error about the delete of temporary zip file. This issue Is gone with this patch. Do you need some screenshot?

@claudiodangelis
Copy link
Owner

Thanks for the prompt response! No screenshot required, just wanted to double check this with you before releasing.
Grazie!

@claudiodangelis claudiodangelis changed the base branch from main to release/0.11.1 December 20, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants