Fixing deleting temporary files #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @vincenzoAiello , thanks for this! I'm reviewing it now, |
|
Hello, I might be missing something, but I don't understand how it fixes the issue with deleting temporary files. |
|
Hello @claudiodangelis, the problem is in the "Create" and "Close" functions because the zip file isn't closed properly. The problem is that the zip file is opened but it is never closed. Only the writer is closed. So, when you try to delete the temporary zip file, it gives an error. BR |
claudiodangelis
added a commit
that referenced
this pull request
Dec 8, 2023
* chore(go-releaser): update version * chore(goreleaser): update config * fix(zip): delete temporary file after transferring it (#304) * Fixing deleting temporary files * style(util): * chore(deps): go mod tidy --------- Co-authored-by: Claudio d'Angelis <claudiodangelis@gmail.com> --------- Co-authored-by: Vincenzo Aiello <vincenzoaiello300@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes deleting temporary files.
I have written again the compression of the files and folders without the using of external libraries.
This resolves the issue #277