Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add react v17 to the peer deps. #768

Merged
merged 1 commit into from
Mar 19, 2021
Merged

Conversation

pleunv
Copy link
Contributor

@pleunv pleunv commented Jan 25, 2021

Hiya!

Not sure if you're still taking PRs, but just in case a quick one in order to add React v17 to the peer deps. Fwiw, I've tested it on v17 and found no issues.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 60a8d69:

Sandbox Source
react-sortable-hoc-starter Configuration

Copy link

@nelsonmestevao nelsonmestevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@jonioni
Copy link

jonioni commented Feb 26, 2021

Can it be merged? Otherwise newly created react projects (^17) cannot adopt this library.

@Develliot
Copy link

@clauderic this library is awesome and we and would love to use it with react 17, could you help us? 🙏

@clauderic clauderic merged commit 888647f into clauderic:master Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants