Fix shift to next row calculation #691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit eb9a56c:
|
|
+1 I'd love to see this merged, this is causing me some headache |
I temporarily published the fix at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue that is happening in this demo (http://clauderic.github.io/react-sortable-hoc/#/basic-configuration/grid?_k=8abqva)
and demonstrated in this issue #626
The calculation that was made to determine if a node has moved past the right bounds is using
offset.widthwhich is only half of the width of the node. This means, if there are more than half of the width of empty space on the right of the container, the node will shift out of the Grid like the image above.resolves #626, resolves #551, resolves #523, resolves #689