Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto scrolling is improved #479

Merged
merged 1 commit into from
Feb 7, 2019
Merged

Auto scrolling is improved #479

merged 1 commit into from
Feb 7, 2019

Conversation

praya
Copy link
Contributor

@praya praya commented Jan 10, 2019

this merge resolves this issue:
#242

@praya
Copy link
Contributor Author

praya commented Jan 10, 2019

@clauderic what do you think about this changes?

@praya praya changed the title Scrolling is improved Auto scrolling is improved Jan 10, 2019
@praya
Copy link
Contributor Author

praya commented Feb 4, 2019

Is anybody here?

@clauderic clauderic merged commit 1a2c87e into clauderic:master Feb 7, 2019
@clauderic
Copy link
Owner

Released in 1.54, thanks!

@praya
Copy link
Contributor Author

praya commented Feb 7, 2019

Thank you!)

@pedrommarquesm
Copy link

pedrommarquesm commented Dec 31, 2021

This somehow got lost in earlier versions. wasn't this mistakenly not frontported to new versions?
The original issue is still reproducible
In version 2.0.0, I found out that whenever a element higher in the DOM has overflow: auto, it breaks the normal behavior.
codesandbox:
https://codesandbox.io/s/broken-sortable-hoc-bqvyi?file=/src/index.js
just comment/uncomment the overflow:auto in the uppermost element (need to refresh everytime the style is modified)

Reproduce steps:
Move item3 to item1 (on left list), check it overflows to the right, into the second list.
Comment out the overflow: auto, observe the previous behavior doesn't happen anymore

Also, change react-sortable-hoc version from 2.0.0 to 1.5.4, and observe that even with the overflow: auto, this does not happen anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants