-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resource azurerm_cdn_frontdoor_secret #5
Conversation
…ins.key_vault_certificate_id
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please update or add an example with this new feature?
Also, you need to update the README file with terraform-docs (CI is failing)
The issue #4 has an example. I just submitted the README fix after installing your pre-commit hooks. Thanks for reviewing. |
Thanks for the README update! |
I apologize because I am not very familiar with pre-commit errors mentioning files outside this git project like the following:
I believe examples/automation-account is from the azurecaf project but I'm not sure why me updating examples/main/modules.tf would cause the above error. What do you suggest I do? |
Hum very weird error, never got that. Maybe bypass pre-commit with the --no-verify param for this one? |
c5edba9
to
29f7212
Compare
29f7212
to
9b01b2a
Compare
Fixes #4 .
Type of change
Changes proposed in this pull request
@claranet/fr-azure-reviewers