Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #11 #13

Merged
merged 1 commit into from
Oct 3, 2022
Merged

Revert #11 #13

merged 1 commit into from
Oct 3, 2022

Conversation

pdecat
Copy link
Member

@pdecat pdecat commented Sep 28, 2022

Revert #11 which broke support for old (v2.0 and older) versions of Zabbix Server.

@pdecat pdecat force-pushed the revert-11-master branch 16 times, most recently from 5259883 to 39bf2af Compare September 28, 2022 22:53
@pdecat
Copy link
Member Author

pdecat commented Sep 28, 2022

Further testing reveals that another API broke with Zabbix Server v5.4+, application was removed completely:

ZBXNEXT-2976 dropped support of whole Application API.

https://www.zabbix.com/documentation/5.4/en/manual/api/changes_5.2_-_5.4#application

[zabbix] Request (POST): {"jsonrpc":"2.0","method":"application.create","params":[{"hostid":"10529","name":"App 5486324351249329442 for fv-az290-762-testing-7300031146395502685"}],"auth":"baf253922a1bc39089e594a50d440de8","id":4}
[zabbix] Response (200): {"jsonrpc":"2.0","error":{"code":-3[26](https://github.com/claranet/go-zabbix-api/actions/runs/3147435342/jobs/5116934981#step:5:27)01,"message":"Method not found.","data":"Incorrect API \"application\"."},"id":4}

https://github.com/claranet/go-zabbix-api/actions/runs/3147435342/jobs/5116934981#step:5:27

@pdecat pdecat changed the title Fix HostsDeleteByIds with Zabbix 6.0+ (take 2) Add Zabbix 5.4+ compatibility Sep 28, 2022
@pdecat pdecat self-assigned this Oct 3, 2022
@pdecat
Copy link
Member Author

pdecat commented Oct 3, 2022

Zabbix 5.4+ compatibility work moved to #15

@pdecat pdecat merged commit a136f8c into master Oct 3, 2022
@pdecat pdecat deleted the revert-11-master branch October 3, 2022 18:05
@pdecat pdecat changed the title Add Zabbix 5.4+ compatibility Revert #11 Oct 3, 2022
pdecat added a commit that referenced this pull request Oct 3, 2022
Revert "Fix HostsDeleteByIds request due to documentation (#11)"

This reverts commit 6f429ab.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant