Bump shlex in clap_complete to 1.3.0 #5702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, we have a dev-dependency on shlex and we can't resolve without dev-dependencies to avoid that from polluting the results. |
|
Can inheriting the version from workspace fix this problem? |
|
I'm avoiding workspace inheritance for now. I want to do it all-or-nothing but
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
shlex::try_quoteis added in 1.3.0 so it is not available in 1.1.0.I guess minimal version CI check didn't detect this problem either because the related features was not active, or since clap itself uses the 1.3.0 and cargo minimal version selector selects a version for the whole workspace.