-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(clap_complete): Support hiding long flags and their long aliases #5583
Conversation
In the process of modifying the code, I feel that |
a4a1f8e
to
6fcced5
Compare
I think its worth keeping. Overuse of tuples can make the code confusing. We were already pushing the use of tuples and this would absolutely break it. Using a struct also offers us more API stability for when we go live with this. |
Thanks for the updates! This is looking great and look forward to the next round of improvements! |
aa3830e
to
858aaf7
Compare
…ing, Option<StyledStr>)`
858aaf7
to
9e5a071
Compare
9e5a071
to
cfe1418
Compare
cfe1418
to
d1e0f60
Compare
Thanks! |
Based on PR: #5549
Related issue: #3951
Works in this PR
CompletionCandidate
to replace(OsString, Option<StyledStr>)
. There will be a new field namedvisible
forCompletionCandidate
. If we don't need this struct, there will be a type(OsString, Option<StyledStr>, bool)
.