fix: Switch to owned OsStr type #4096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a part of clap-rs#1041 Because `Option<Into<T>>` is ambiguous for `None`, we had to create `Resettable` to workaround it.
With being able to accept owned types now, `clap_derive` no longer needs `once_cell` to make dynamic data static. This helps towards clap-rs#1365, clap-rs#2037
epage
added a commit
to epage/clap
that referenced
this pull request
Aug 29, 2022
PR clap-rs#4096 made them redundant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another step towards #1041
This allowed removing a dependency as well which helps towards #2037