fix(help): Always respect DisableColoredHelp #3305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We might be able to handle version/help before propagation but I didn't want to hold up this fix for that to happen and increase the risk associated with this fix. Fixes clap-rs#3298
The main motivation was to reduce special cases by putting all of the logic in one place.
epage
added a commit
to epage/clap
that referenced
this pull request
Jan 18, 2022
I thought I was adding a test in clap-rs#3305. Maybe I considered the clap_complete changes sufficient for this. Doing more `debug_assert`s would be good also. Unsetting `PropagateVersion` helps in some cases but we need to unset it globally to override the global propagation. Fixes clap-rs#3310
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We might be able to handle version/help before propagation but I didn't
want to hold up this fix for that to happen and increase the risk
associated with this fix.
Fixes #3298