Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bash completions #1180

Merged
merged 3 commits into from
Feb 13, 2018
Merged

Bash completions #1180

merged 3 commits into from
Feb 13, 2018

Conversation

kbknapp
Copy link
Member

@kbknapp kbknapp commented Feb 13, 2018 •
edited
Loading

Closes #1179

This change is Reviewable

@kbknapp
imp(Bash Completions): instead of completing a generic option name, a…
872f02a 
…ll bash completions fall back to file completions UNLESS Arg::possible_values was used
@kbknapp
tests(Bash Completions): updates the bash completions to the new file…
84c7896 
… completion fallback
@mention-bot
Copy link

@kbknapp, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kbknapp to be a potential reviewer.

@kbknapp kbknapp merged commit ebe1455 into master Feb 13, 2018
@kbknapp kbknapp deleted the bash-completions branch February 13, 2018 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kbknapp @mention-bot