Merge pull request #5136 from epage/panic

fix(assert): Call out the action in positional assert
clap-rs · Sep 25, 2023 · 0d9b14f · 0d9b14f
2 parents cb2d2bc + 221177b
commit 0d9b14f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/clap_builder/src/builder/debug_asserts.rs b/clap_builder/src/builder/debug_asserts.rs
@@ -746,8 +746,9 @@ fn assert_arg(arg: &Arg) {
         );
         assert!(
             arg.is_takes_value_set(),
-            "Argument '{}` is positional, it must take a value{}",
+            "Argument '{}` is positional and it must take a value but action is {:?}{}",
             arg.get_id(),
+            arg.get_action(),
             if arg.get_id() == Id::HELP {
                 " (`mut_arg` no longer works with implicit `--help`)"
             } else if arg.get_id() == Id::VERSION {

diff --git a/tests/builder/multiple_values.rs b/tests/builder/multiple_values.rs
@@ -1730,7 +1730,7 @@ fn issue_2229() {
 }
 
 #[test]
-#[should_panic = "Argument 'pos` is positional, it must take a value"]
+#[should_panic = "Argument 'pos` is positional and it must take a value but action is SetTrue"]
 fn disallow_positionals_without_values() {
     let cmd = Command::new("test").arg(Arg::new("pos").num_args(0));
     cmd.debug_assert();