Skip to content

Commit

Permalink
nfc: nxp-nci: Fix potential memory leak in nxp_nci_send()
Browse files Browse the repository at this point in the history
nxp_nci_send() won't free the skb when it failed for the check before
write(). As the result, the skb will memleak. Free the skb when the
check failed.

Fixes: dece458 ("NFC: nxp-nci: Add support for NXP NCI chips")
Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
Suggested-by: Pavel Machek <pavel@denx.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Shang XiaoJing authored and davem330 committed Nov 21, 2022
1 parent e204ead commit 614761e
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions drivers/nfc/nxp-nci/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -73,11 +73,15 @@ static int nxp_nci_send(struct nci_dev *ndev, struct sk_buff *skb)
struct nxp_nci_info *info = nci_get_drvdata(ndev);
int r;

if (!info->phy_ops->write)
if (!info->phy_ops->write) {
kfree_skb(skb);
return -EOPNOTSUPP;
}

if (info->mode != NXP_NCI_MODE_NCI)
if (info->mode != NXP_NCI_MODE_NCI) {
kfree_skb(skb);
return -EINVAL;
}

r = info->phy_ops->write(info->phy_id, skb);
if (r < 0) {
Expand Down

0 comments on commit 614761e

Please sign in to comment.