Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test special filenames, non-ascii and special html characters #7

Open
clach04 opened this issue Sep 5, 2022 · 2 comments
Open

test special filenames, non-ascii and special html characters #7

clach04 opened this issue Sep 5, 2022 · 2 comments

Comments

@clach04
Copy link
Owner

clach04 commented Sep 5, 2022

Test:

  • ✔️ something that's not 7-bit US-ACII, for example which is not the 7-bit ascii hypen
    • required 7c893bb
    • Example test_book_–1.txt
  • special html escape character sequence, &, #, ?
    • Example test_book_#1.txt
    • Example test_book_¥.txt
  • also check check special directory names - not just filenames

demo directory:

$ ls -a sample_reading_media/dir\ with\ spaces/
 .                      'double_quotes_"name"_epub.epub'  'square_brackets_[name]_epub.epub'
 ..                     "single_quotes_'name'_epub.epub"  'test book epub.epub'
'ampersand_&epub.epub'  'spaces book epub.epub'            test_book_epub.epub
'test_with_greater_than_html<1>_epub.epub'

Samples

using https://github.com/clach04/sample_reading_media/

$ find sample_reading_media/
sample_reading_media/
sample_reading_media/epubs
sample_reading_media/epubs/test_book_epub.epub
sample_reading_media/epubs/test_book(epub).epub
sample_reading_media/epubs/test book epub.epub
sample_reading_media/epubs/test book (epub).epub
sample_reading_media/test_book_fb2.fb2
sample_reading_media/test_book.md
sample_reading_media/test_book_txt.txt
sample_reading_media/test_book_epub.epub
sample_reading_media/test_book_pdf.pdf
sample_reading_media/test_book_md.md
sample_reading_media/test_book_odt.odt
sample_reading_media/test_book_docx.docx
sample_reading_media/test_book_fb2_zip.zip
sample_reading_media/test_book_html.html
sample_reading_media/empty_dir
sample_reading_media/single_quote_search_filename_problem
sample_reading_media/single_quote_search_filename_problem/test_book_epub.epub
sample_reading_media/single_quote_search_filename_problem/single_quotes_'name'_epub.epub
sample_reading_media/single_quote_search_filename_problem/test_with_greater_than_html<1>_epub.epub
sample_reading_media/dir with spaces
sample_reading_media/dir with spaces/double_quotes_"name"_epub.epub
sample_reading_media/dir with spaces/test_book_epub.epub
sample_reading_media/dir with spaces/square_brackets_[name]_epub.epub
sample_reading_media/dir with spaces/spaces book epub.epub
sample_reading_media/dir with spaces/ampersand_&epub.epub
sample_reading_media/dir with spaces dupe
sample_reading_media/dir with spaces dupe/double_quotes_"name"_epub.epub
sample_reading_media/dir with spaces dupe/test_book_epub.epub
sample_reading_media/dir with spaces dupe/single_quotes_'name'_epub.epub
sample_reading_media/dir with spaces dupe/square_brackets_[name]_epub.epub
sample_reading_media/dir with spaces dupe/spaces book epub.epub
sample_reading_media/dir with spaces dupe/ampersand_&epub.epub
sample_reading_media/test_book_txt_zip.zip
sample_reading_media/test_book_html_zip.zip
sample_reading_media/test_book_md_zip.zip

Notes

  • 🔴 sample_reading_media/dir with spaces/double_quotes_"name"_epub.epub - good sample, bug in web version (seems to expose a KoReader behavior (possible weebok OPDS server bug)?
  • ampersand_&epub.epub - fine in both :-)
  • double quotes is a legal filename under Linux (Android?) but NOT Microsoft Windows
clach04 added a commit that referenced this issue Sep 5, 2022
@clach04
Copy link
Owner Author

clach04 commented Sep 5, 2022

ampersand handled via 6d92dbe

pound/hash '#' is a browser issue

@clach04
Copy link
Owner Author

clach04 commented Jan 8, 2023

Greater than and less than handled via ef2493e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant