fix: remove required variables from ADR template#38
Merged
Conversation
The ADR template expected adr_number and adr_title variables during project initialization, but these variables are only known when creating specific ADRs after the project exists. This caused project creation to fail with "Missing required variables" error. Solution: Convert template from Jinja2 template to static reference file with plain text placeholders (ADR-XXX, YYYY-MM-DD, Proposed). Template now renders successfully during project init and serves as a clear example for users to copy when creating new ADRs. Fixes: agentspaces-qfu
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
src/agentspaces/templates/skeleton/docs/adr/000-template.mdadr_numberandadr_titlefrom required variablesProblem
The ADR template required variables (
adr_number,adr_title) that are only known when creating specific ADRs after project initialization, causingagentspaces project createto fail with "Missing required variables" error.Solution
Convert template to static reference file with clear placeholders. Template now renders successfully during project init and serves as a scaffold for users creating new ADRs.
Testing
Verification
Fixes: agentspaces-qfu