Skip to content

Commit

Permalink
Default module kind to NoModule in ScalaJs
Browse files Browse the repository at this point in the history
This better aligns with the defaults users coming from sbt land or going
to sbt where Scalajs will default to NoModule. This also allows a JS
file produced by package to more easily be incuded in an html file if no
further linking is required.

Closes VirtusLab#338
  • Loading branch information
ckipp01 committed Nov 3, 2021
1 parent 978b055 commit 0e42877
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ final case class ScalaJsOptions(
case "commonjs" | "common" => ModuleKind.CommonJSModule
case "esmodule" | "es" => ModuleKind.ESModule
case "nomodule" | "none" => ModuleKind.NoModule
case _ => ModuleKind.CommonJSModule
case _ => ModuleKind.NoModule
}

def finalVersion = version.map(_.trim).filter(_.nonEmpty).getOrElse(Constants.scalaJsVersion)
Expand Down

0 comments on commit 0e42877

Please sign in to comment.