Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs nested blockquotes fix #9472

Merged
merged 16 commits into from
Apr 20, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,35 +1,26 @@
<div id="snippet-nested-block-quote">
<h3>The Gagarin mixup</h3>

<p>Misquoting is more widespread than one may think. And it may happen to almost anybody. Sometimes it would be an accident, but sometimes you may consider this a conscious act. One of the better known cases is something a Soviet cosmonaut, Yuri Gagarin, was supposed to say &mdash; but apparently never said. The infamous quote goes:</p>
<p>Re: Material usage information</p>

<blockquote>
<p>I looked and looked but I didn&#39;t see God.</p>
</blockquote>

<p>Let us refer to the <strong>Yuri Gagarin's</strong> <a href="https://en.wikiquote.org/wiki/Yuri_Gagarin#Disputed">Wikiquote page</a> on that topic and dig further into this particular case study, as it offers a plausible and factual explanation of this mess-up:</p>
<blockquote>
<p>Tom,</p>

<blockquote>
<p>Colonel Valentin Petrov stated in 2006&nbsp;that the cosmonaut never said such words, and that the quote originated from Nikita Khrushchev&#39;s speech at the plenum of the Central Committee of the CPSU about the state&#39;s anti-religion campaign, saying:</p>
<p>This is just a reminder that we need the data for our Friday meeting with the external subcontractors. Can you please let me know, if all the reports are ready?</p>

<blockquote>Gagarin flew into space, but didn&#39;t see any god there.</blockquote>
<p>Zoe</p>
</blockquote>

<p>Gagarin himself was a member of the Russian Orthodox Church.</p>
</blockquote>
<p>Hi Zoe,</p>

<p>It looks like a cunning rhetoric to support an ideological point of view and you may even suppose the cosmonaut himself was not personally involved in it. Quite honestly, being a believer, he would have a hard time denying the existence of God. It is something Gherman Titov, the second Soviet cosmonaut, would rather say, being an atheist.</p>
<p>The reports are coming in, but the Q3 data is still missing. As far as I can tell, Shizuoka is behind the schedule with the final summary and the Expansion Department has not released their numbers yet. I will reach out to both and will keep you informed on that topic by noon, tomorrow.</p>

<p>It was, in fact, duly noted in <i>The New York Times</i>, dated May 7, 1962:</p>
<blockquote>
Maj. Gherman S. Titov, the Soviet astronaut, proclaimed his disbelief in God today. He said he saw
<blockquote>no God or angels</blockquote>
during his seventeen orbits of the earth.
<p>Tom</p>
</blockquote>

<p>A similar statement by Titov was also reported by Pavel Barashev and Yuri Dokuchayev, so it seems this was not entirely made up by Khrushchev, but rather reused and falsely attributed to the Earth's first space farer.</p>
<p>Please do so, this is getting urgent. Contact Haleema from ED directly. Also check Shizuoka, this is very much unlike him to leave such an important matter for the last moment.</p>

<p>Apparently there was more than one source involved in the origin of this misunderstanding. As you can see, sometimes, just like in the case of the notorious &quot;Einstein fish&quot;, things can get messed up pretty easily. And it takes a lot of time to debunk them, as there are numerous occurrences of the quote that <i>partially</i> support the case.</p>
<p>Hope to have this ready for review at the 2pm board meeting provided you can manage to prepare a summary and to have the full data by Thursday morning at the latest.</p>

<p>This is why you should always check your sources twice and, if necessary, quote them!</p>
<p>Zoe</p>

</div>
6 changes: 4 additions & 2 deletions packages/ckeditor5-block-quote/docs/features/block-quote.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,11 @@ Use the editor below to see the block quote plugin in action. You can also prece

{@snippet features/block-quote}

## Nesting block quotes
## Nested block quotes

Starting from version 27.1.0, CKEditor 5 supports nesting a block quote in another block quote. This may prove useful for scientific or academic papers, but also articles citing sources and referring to previous writing would often use it. To use this functionality, simply click where you need the quote nested and insert it just like a regular one.
Starting from version 27.1.0, CKEditor 5 will properly display a block quote nested in another block quote. This sort of structure is indispensable in email editors or discussion forums. The ability to cite previous messages and preserve a correct quotation structure is often crucial to maintain the flow of communication. Nested block quotes may also prove useful for scientific or academic papers, but articles citing sources and referring to previous writing would often use it, too.

Support for nested block quotes is provided as backward compatibility for loading pre-existing content, for example created in CKEditor 4. Additionally, pasting content with nested block quotes is supported. You can also nest a block quote in another block quote using the {@link features/drag-drop drag and drop} mechanism &mdash; just select an existing block quote and drag it into another.

{@snippet features/nested-block-quote}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -419,8 +419,6 @@ schema.register( 'blockQuote', {

Thanks to that, despite the fact that block quote and paragraph features know nothing about themselves, paragraphs will be allowed in block quotes and block quotes will be allowed in all places where blocks are allowed. So if anyone registers a `<section>` element (with the `allowContentOf: '$root'` rule), that `<section>` elements will allow block quotes, too.

The side effect of such a definition inheritance is that now `<blockQuote>` is allowed in `<blockQuote>` which needs to be resolved by a callback which will disallow this specific structure.

<info-box>
You can read more about the format of the item definition in {@link module:engine/model/schema~SchemaItemDefinition}.
</info-box>
Expand Down