Model#insertContent() should properly auto-paragraph nodes #8958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niegowski
commented
Feb 1, 2021
Comment on lines
+257
to
+261
| if ( this.position.parent != node || !this.position.isAtEnd ) { | ||
| // Algorithm's correctness check. We should never end up here but it's good to know that we did. | ||
| // At this point the insertion position should be at the end of the last auto paragraph. | ||
| // Note: This error is documented in other place in this file. | ||
| throw new CKEditorError( 'insertcontent-invalid-insertion-position', this ); |
There was a problem hiding this comment.
This is a clone of the previous check that is in _mergeOnRight() but this is a slightly different scenario.
|
LGTM. Do we want @ckeditor/qa-team to check it before merging? |
I guess we should 😉 |
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix (engine): Pasting formatted single-line text over a widget should not split it into multiple paragraphs. Closes #8953.
Additional information