Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved a check for pasting the nesting lists in PFO #8417

Merged
merged 5 commits into from
Nov 5, 2020
Merged

Conversation

pomek
Copy link
Member

@pomek pomek commented Nov 5, 2020

Suggested merge commit message (convention)

Fix (paste-from-office): Improved a mechanism that detects nested lists while pasting from Word. In some scenarios, pasting nested lists could produce invalid results in the editor. Closes #7805.

@pomek pomek requested a review from jodator November 5, 2020 11:12
@pomek pomek changed the title Improved a check for nesting lists in PFO Improved a check for pasting the nesting lists in PFO Nov 5, 2020
Copy link
Contributor

@jodator jodator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have words for the Word issues anymore... This case looks solved 👍 .

I've added full links to the issue as you need to quickly browse the GH in case you really want to understand the story behind.

I've updated one thing in the comment so hopefully, I get that one right.

packages/ckeditor5-paste-from-office/src/filters/list.js Outdated Show resolved Hide resolved
packages/ckeditor5-paste-from-office/src/filters/list.js Outdated Show resolved Hide resolved
packages/ckeditor5-paste-from-office/src/filters/list.js Outdated Show resolved Hide resolved
@jodator jodator merged commit be5b989 into master Nov 5, 2020
@jodator jodator deleted the i/7805 branch November 5, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

paste-from-office: Losing indent level for nested lists of different type (numbered, bullet)
2 participants