Skip to content

Enabled slack notifier for failures on branch master-v48. #19482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pomek merged 5 commits into from
Dec 8, 2025
+11 −3
Merged

Enabled slack notifier for failures on branch master-v48. #19482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ef1df5b
Pinned CKBox version.
przemyslaw-zan Dec 3, 2025
7bed482
Merge pull request #19474 from ckeditor/ci/4183
przemyslaw-zan Dec 5, 2025
21de6f7
Enabled slack notifier for failures on branch `master-v48`.
martnpaneq Dec 5, 2025
9121d3c
Added `master-v48` branch to handle nightly CI job.
martnpaneq Dec 5, 2025
01eaf23
Merge branch 'master' into i/4189
pomek Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .circleci/template.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,6 +332,8 @@ workflows:
branches:
only:
- master
# TODO: Remove when this code lands on #master (see issue https://github.com/ckeditor/ckeditor5-internal/issues/4190).
- master-v48
- stable
- release
- /^release-v.*$/
Expand Down
2 changes: 1 addition & 1 deletion packages/ckeditor5-theme-lark/docs/_snippets/examples/theme-lark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ class DarkModeCKBoxIntegration extends Plugin {
// Load CKBox dark theme.
this._ckboxLinkElement = document.createElement( 'link' );
this._ckboxLinkElement.rel = 'stylesheet';
this._ckboxLinkElement.href = 'https://cdn.ckbox.io/ckbox/latest/styles/themes/dark.css';
this._ckboxLinkElement.href = 'https://cdn.ckbox.io/ckbox/2.9.2/styles/themes/dark.css';

document.head.appendChild( this._ckboxLinkElement );

Expand Down
4 changes: 2 additions & 2 deletions scripts/docs/snippetadapter.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,10 +204,10 @@ async function buildDocuments( snippets, paths, constants, imports, getSnippetPl
'<link rel="modulepreload" href="%BASE_PATH%/assets/ckeditor5/ckeditor5.js">',
'<link rel="modulepreload" href="%BASE_PATH%/assets/ckeditor5-premium-features/ckeditor5-premium-features.js">',
'<link rel="preload" href="%BASE_PATH%/assets/global.js" as="script">',
'<link rel="preload" href="https://cdn.ckbox.io/ckbox/latest/ckbox.js" as="script">',
'<link rel="preload" href="https://cdn.ckbox.io/ckbox/2.9.2/ckbox.js" as="script">',
`<script>window.CKEDITOR_GLOBAL_LICENSE_KEY = '${ constants.LICENSE_KEY }';</script>`,
'<script src="%BASE_PATH%/assets/global.js"></script>',
'<script src="https://cdn.ckbox.io/ckbox/latest/ckbox.js"></script>',
'<script src="https://cdn.ckbox.io/ckbox/2.9.2/ckbox.js"></script>',
getLayeredStyles( 'editor', editorStylePaths )
];

Expand Down
6 changes: 6 additions & 0 deletions scripts/release/utils/parsearguments.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,12 @@ export default function parseArguments( cliArguments ) {
options.npmTag = 'alpha';
}

// TODO: Remove when this code lands on #master (see issue https://github.com/ckeditor/ckeditor5-internal/issues/4190).
if ( options.nightlyNext ) {
options.branch = 'master-v48';
options.npmTag = 'nightly-next';
}

if ( options.internal ) {
options.npmTag = 'internal';
}
Expand Down