Fix incorrect move of table row containing only th elements to thead if previous row was not header row (v47.x)#19448
Merged
Mati365 merged 1 commit intock/feat/table-cell-type-v47from Nov 26, 2025
Conversation
…ad` if previous row was not header row.
Mati365
changed the title
th elements to thead if previous row was not header row.th elements to thead if previous row was not header row (v47.x)
pszczesniak
reviewed
Nov 26, 2025
Contributor
pszczesniak
left a comment
pszczesniak
left a comment
There was a problem hiding this comment.
👍
Just one thing to consider.
| * @internal | ||
| */ | ||
| export function upcastTable() { | ||
| export function upcastTable( editor: Editor ) { |
Contributor
There was a problem hiding this comment.
Maybe would be good to pass only the config flag value with default set to false instead of editor instance?
This function Is re-exported as an internal function but maybe we can add a fallback for the parameter.
Contributor
There was a problem hiding this comment.
Ok, it will be removed in v48.
pszczesniak
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Summary
Fix incorrect move of table row containing only
thelements totheadif previous row was not header row.It's change for
v47version of the editor.📌 Related issues
theadshould not be gready and should not move all th to thethead#19431