Skip to content

Conversation

@Mati365
Copy link
Member

@Mati365 Mati365 commented Mar 18, 2024

Suggested merge commit message (convention)

Feature (ui): Added the ability to move the mouse cursor to the tooltip without it closing.
Feature (ui): Introduced support for closing tooltips using the Escape key.


Additional information

Closes https://github.com/cksource/ckeditor5-commercial/issues/6039.
Related to https://github.com/cksource/ckeditor5-commercial/pull/6098

@Mati365 Mati365 marked this pull request as ready for review March 18, 2024 12:44
@Mati365 Mati365 requested review from DawidKossowski and oleq March 20, 2024 12:22
Copy link
Member

@oleq oleq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we delay the hiding of the tooltip? It's very hard to move a cursor to it because it hides right away unless the cursor moves perfectly along the "^" (arrow pseudo-element). See the screencast below.

Screen.Recording.2024-03-25.at.14.26.02.mov

Copy link
Member

@oleq oleq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic responsible for showing tooltips is broken after recent changes

Screen.Recording.2024-03-25.at.16.16.51.mov

@Mati365 Mati365 requested a review from oleq March 26, 2024 06:55
@Mati365
Copy link
Member Author

Mati365 commented Mar 26, 2024

@oleq Fixed, can you check again?

@oleq oleq merged commit 7df13e9 into master Mar 26, 2024
@oleq oleq deleted the ck/6039 branch March 26, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants