-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add tests GHS style integration plugin and for DomConverter style rep…
…lacement.
- Loading branch information
Maksymilian Barnaś
committed
Feb 8, 2022
1 parent
daa10d4
commit 003e537
Showing
4 changed files
with
254 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
179 changes: 179 additions & 0 deletions
179
packages/ckeditor5-html-support/tests/integrations/style.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,179 @@ | ||
| /** | ||
| * @license Copyright (c) 2003-2022, CKSource Holding sp. z o.o. All rights reserved. | ||
| * For licensing, see LICENSE.md or https://ckeditor.com/legal/ckeditor-oss-license | ||
| */ | ||
|
|
||
| import ClassicTestEditor from '@ckeditor/ckeditor5-core/tests/_utils/classictesteditor'; | ||
| import Paragraph from '@ckeditor/ckeditor5-paragraph/src/paragraph'; | ||
| import GeneralHtmlSupport from '../../src/generalhtmlsupport'; | ||
| import { getModelDataWithAttributes } from '../_utils/utils'; | ||
| import { getData as getModelData } from '@ckeditor/ckeditor5-engine/src/dev-utils/model'; | ||
|
|
||
| /* global console, document */ | ||
|
|
||
| describe( 'StyleElementSupport', () => { | ||
| const STYLE = 'div { color: red; }'; | ||
| const CODE_CPP = 'cout << "Hello World" << endl;'; | ||
|
|
||
| let editor, model, editorElement, dataFilter, warnStub; | ||
|
|
||
| beforeEach( async () => { | ||
| editorElement = document.createElement( 'div' ); | ||
| document.body.appendChild( editorElement ); | ||
|
|
||
| editor = await ClassicTestEditor.create( editorElement, { | ||
| plugins: [ Paragraph, GeneralHtmlSupport ] | ||
| } ); | ||
| model = editor.model; | ||
| dataFilter = editor.plugins.get( 'DataFilter' ); | ||
|
|
||
| dataFilter.allowElement( 'style' ); | ||
|
|
||
| warnStub = sinon.stub( console, 'warn' ); | ||
| } ); | ||
|
|
||
| afterEach( () => { | ||
| warnStub.restore(); | ||
| editorElement.remove(); | ||
|
|
||
| return editor.destroy(); | ||
| } ); | ||
|
|
||
| it( 'should allow element', () => { | ||
| editor.setData( `<p>Foo</p><style>${ STYLE }</style>` ); | ||
|
|
||
| expect( getModelData( model, { withoutSelection: true } ) ).to.equal( | ||
| `<paragraph>Foo</paragraph><htmlStyle htmlContent="${ STYLE }"></htmlStyle>` | ||
| ); | ||
|
|
||
| expect( editor.getData() ).to.equal( `<p>Foo</p><style>${ STYLE }</style>` ); | ||
| } ); | ||
|
|
||
| it( 'should allow attributes', () => { | ||
| dataFilter.allowAttributes( { name: 'style', attributes: [ 'type', 'nonce' ] } ); | ||
|
|
||
| editor.setData( `<p>Foo</p><style type="c++" nonce="qwerty">${ CODE_CPP }</style>` ); | ||
|
|
||
| expect( getModelDataWithAttributes( model, { withoutSelection: true } ) ).to.deep.equal( { | ||
| data: `<paragraph>Foo</paragraph><htmlStyle htmlAttributes="(1)" htmlContent="${ CODE_CPP }"></htmlStyle>`, | ||
| attributes: { | ||
| 1: { | ||
| attributes: { | ||
| nonce: 'qwerty', | ||
| type: 'c++' | ||
| } | ||
| }, | ||
| 2: CODE_CPP | ||
| } | ||
| } ); | ||
|
|
||
| expect( editor.getData() ).to.equal( `<p>Foo</p><style type="c++" nonce="qwerty">${ CODE_CPP }</style>` ); | ||
| } ); | ||
|
|
||
| it( 'should disallow attributes', () => { | ||
| dataFilter.allowAttributes( { name: 'style', attributes: true } ); | ||
| dataFilter.disallowAttributes( { name: 'style', attributes: 'nonce' } ); | ||
|
|
||
| editor.setData( `<p>Foo</p><style type="c++" nonce="qwerty">${ CODE_CPP }</style>` ); | ||
|
|
||
| expect( getModelDataWithAttributes( model, { withoutSelection: true } ) ).to.deep.equal( { | ||
| data: `<paragraph>Foo</paragraph><htmlStyle htmlAttributes="(1)" htmlContent="${ CODE_CPP }"></htmlStyle>`, | ||
| attributes: { | ||
| 1: { | ||
| attributes: { | ||
| type: 'c++' | ||
| } | ||
| }, | ||
| 2: CODE_CPP | ||
| } | ||
| } ); | ||
|
|
||
| expect( editor.getData() ).to.equal( `<p>Foo</p><style type="c++">${ CODE_CPP }</style>` ); | ||
| } ); | ||
|
|
||
| describe( 'element position', () => { | ||
| const testCases = [ { | ||
| name: 'paragraph', | ||
| data: `<article><section><p>Foo<style>${ STYLE }</style>Bar</p></section></article>`, | ||
| model: | ||
| '<htmlArticle>' + | ||
| `<htmlSection><paragraph>Foo<htmlStyle htmlContent="${ STYLE }"></htmlStyle>Bar</paragraph></htmlSection>` + | ||
| '</htmlArticle>' | ||
| }, { | ||
| name: 'section', | ||
| data: `<article><section><p>Foo</p><style>${ STYLE }</style></section></article>`, | ||
| model: | ||
| '<htmlArticle>' + | ||
| `<htmlSection><paragraph>Foo</paragraph><htmlStyle htmlContent="${ STYLE }"></htmlStyle></htmlSection>` + | ||
| '</htmlArticle>' | ||
| }, { | ||
| name: 'article', | ||
| data: `<article><section><p>Foo</p></section><style>${ STYLE }</style></article>`, | ||
| model: | ||
| '<htmlArticle>' + | ||
| `<htmlSection><paragraph>Foo</paragraph></htmlSection><htmlStyle htmlContent="${ STYLE }"></htmlStyle>` + | ||
| '</htmlArticle>' | ||
| }, { | ||
| name: 'root', | ||
| data: `<article><section><p>Foo</p></section></article><style>${ STYLE }</style>`, | ||
| model: | ||
| '<htmlArticle><htmlSection><paragraph>Foo</paragraph></htmlSection></htmlArticle>' + | ||
| `<htmlStyle htmlContent="${ STYLE }"></htmlStyle>` | ||
| } ]; | ||
|
|
||
| for ( const { name, data, model: modelData } of testCases ) { | ||
| it( `should allow element inside ${ name }`, () => { | ||
| dataFilter.allowElement( 'article' ); | ||
| dataFilter.allowElement( 'section' ); | ||
|
|
||
| editor.setData( data ); | ||
|
|
||
| expect( getModelData( model, { withoutSelection: true } ) ).to.equal( modelData ); | ||
|
|
||
| expect( editor.getData() ).to.equal( data ); | ||
| } ); | ||
| } | ||
| } ); | ||
|
|
||
| it( 'should not consume attributes already consumed (downcast)', () => { | ||
| dataFilter.allowAttributes( { name: 'style', attributes: true } ); | ||
|
|
||
| editor.conversion.for( 'downcast' ).add( dispatcher => { | ||
| dispatcher.on( 'attribute:htmlAttributes:htmlStyle', ( evt, data, conversionApi ) => { | ||
| conversionApi.consumable.consume( data.item, evt.name ); | ||
| }, { priority: 'high' } ); | ||
| } ); | ||
|
|
||
| editor.setData( `<p>Foo</p><style nonce="qwerty">${ STYLE }</style>` ); | ||
|
|
||
| expect( getModelDataWithAttributes( model, { withoutSelection: true } ) ).to.deep.equal( { | ||
| data: `<paragraph>Foo</paragraph><htmlStyle htmlAttributes="(1)" htmlContent="${ STYLE }"></htmlStyle>`, | ||
| attributes: { | ||
| 1: { attributes: { nonce: 'qwerty' } }, | ||
| 2: STYLE | ||
| } | ||
| } ); | ||
|
|
||
| expect( editor.getData() ).to.equal( `<p>Foo</p><style>${ STYLE }</style>` ); | ||
| } ); | ||
|
|
||
| it( 'should not consume attributes already consumed (upcast)', () => { | ||
| dataFilter.allowAttributes( { name: 'style', attributes: true } ); | ||
|
|
||
| editor.conversion.for( 'upcast' ).add( dispatcher => { | ||
| dispatcher.on( 'element:style', ( evt, data, conversionApi ) => { | ||
| conversionApi.consumable.consume( data.viewItem, { attributes: 'nonce' } ); | ||
| }, { priority: 'high' } ); | ||
| } ); | ||
|
|
||
| editor.setData( `<p>Foo</p><style type="text/css" nonce="qwerty">${ STYLE }</style>` ); | ||
|
|
||
| expect( getModelDataWithAttributes( model, { withoutSelection: true } ) ).to.deep.equal( { | ||
| data: `<paragraph>Foo</paragraph><htmlStyle htmlAttributes="(1)" htmlContent="${ STYLE }"></htmlStyle>`, | ||
| attributes: { | ||
| 1: { attributes: { type: 'text/css' } }, | ||
| 2: STYLE | ||
| } | ||
| } ); | ||
| } ); | ||
| } ); |