Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Commit

Permalink
Merge pull request #247 from ckeditor/t/ckeditor5-image/312
Browse files Browse the repository at this point in the history
Tests: Return editor promise from asynchronous tests.
  • Loading branch information
Reinmar authored Sep 3, 2019
2 parents ece87bc + 3980920 commit f5fde63
Showing 1 changed file with 6 additions and 10 deletions.
16 changes: 6 additions & 10 deletions tests/linkediting.js
Original file line number Diff line number Diff line change
Expand Up @@ -621,8 +621,8 @@ describe( 'LinkEditing', () => {
} );

describe( 'upcast converter', () => {
it( 'should upcast attributes from initial data', done => {
VirtualTestEditor
it( 'should upcast attributes from initial data', () => {
return VirtualTestEditor
.create( {
initialData: '<p><a href="url" target="_blank" rel="noopener noreferrer" download="file">Foo</a>' +
'<a href="example.com" download="file">Bar</a></p>',
Expand Down Expand Up @@ -657,13 +657,11 @@ describe( 'LinkEditing', () => {
'<$text linkHref="example.com" linkIsDownloadable="true">Bar</$text>' +
'</paragraph>'
);
} )
.then( done )
.catch( done );
} );
} );

it( 'should not upcast partial and incorrect attributes', done => {
VirtualTestEditor
it( 'should not upcast partial and incorrect attributes', () => {
return VirtualTestEditor
.create( {
initialData: '<p><a href="url" target="_blank" download="something">Foo</a>' +
'<a href="example.com" download="test">Bar</a></p>',
Expand Down Expand Up @@ -698,9 +696,7 @@ describe( 'LinkEditing', () => {
'<$text linkHref="example.com">Bar</$text>' +
'</paragraph>'
);
} )
.then( done )
.catch( done );
} );
} );
} );
} );
Expand Down

0 comments on commit f5fde63

Please sign in to comment.