Skip to content

Migrate npm publishing to OIDC (master-v54) - #1447

Merged
pomek merged 2 commits into
master-v54from
ci/4654-oidc-v54
Jul 28, 2026
Merged

pomek merged 2 commits into
master-v54from
ci/4654-oidc-v54

Conversation

@pomek

@pomek pomek commented Jul 28, 2026

Copy link
Copy Markdown
Member

🚀 Summary

Migrates the release workflow from the long-lived CKE5_NPM_TOKEN to npm Trusted Publishing with CircleCI OIDC.

The PR also:

  • Installs npm ^11.11.0 in the release job because the cimg/node:24.11.0 image ships an npm version whose OIDC implementation does not recognize CircleCI (support was added in feat: adds circleci to oidc npm/cli#8925, first released in npm 11.11.0).
  • Configures releaseTools.publishPackages() to use OIDC (useOidc: true) and removes the login-based npmOwner option, as npm whoami does not support OIDC authentication.
  • Switches the origin remote to SSH and pins GitHub's published Ed25519 host key so the release commit and tag can be pushed from the GitHub App checkout without an interactive prompt.
  • Adds a focused script test verifying the OIDC option and the absence of npmOwner.

The trigger command already passes --pipeline-definition-id, so no trigger changes were needed. The changes mirror the Mrgit and Umberto migrations driven by ckeditor/ckeditor5-internal#4432.

This is the master-v54 port of the same change (the release publishes with --npm-tag latest-v54).


📌 Related issues


💡 Additional information

This is an internal CI change, so no changelog entry is required. ESLint and script tests pass locally, and the trusted publisher configuration inputs (organization, project, and pipeline definition IDs) were verified against the CircleCI API. The workspace @ckeditor/ckeditor5-dev-release-tools already provides useOidc on this branch. Before the first release on this flow, trusted publishers for all published packages must be configured on npm, and a release after merge is required to validate the OIDC exchange with npm end to end.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 2230b5e. Configure here.

Comment thread .circleci/template.yml
@pomek
pomek merged commit c818835 into master-v54 Jul 28, 2026
8 checks passed
@pomek
pomek deleted the ci/4654-oidc-v54 branch July 28, 2026 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants