Skip to content

Conversation

@pomek
Copy link
Member

@pomek pomek commented May 20, 2025

Suggested merge commit message (convention)

Feature (utils): The package sources are now written in TypeScript. The package exposes its typings. Closes ckeditor/ckeditor5#18324.

Feature (utils): Created new namespaces: workspaces and npm.

  • workspaces exposes the following functions:
    • findPathsToPackages()
    • getPackageJson()
    • getRepositoryUrl()
  • npm exposes the following functions:
    • checkVersionAvailability()
    • manifest() - a wrapper over the packote package that prevents using any cache
    • packument() - as above.

Other (release-tools): The following functions are no longer exposed by the package:

  • checkVersionAvailability()
  • findPathsToPackages()

MAJOR BREAKING CHANGE (release-tools): The checkVersionAvailability() function has been moved to the @ckeditor/ckeditor5-dev-utils within the npm namespace.

MAJOR BREAKING CHANGE (release-tools): The findPathsToPackages() function has been moved to the @ckeditor/ckeditor5-dev-utils within the workspaces namespace.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@pomek pomek changed the base branch from master to epic/ck/18051-changeset May 20, 2025 12:07
@pomek
Copy link
Member Author

pomek commented May 20, 2025

As the ckeditor5-dev-utils is used by ckeditor5-dev-tests, I did a quick check in CKEditor 5:

  • test -f emoji
    image

  • manual -f slash-command

     $ node --max_old_space_size=8192 node_modules/@ckeditor/ckeditor5-dev-tests/bin/testmanual.js -f slash-command
     Removed directory '/home/pomek/Projects/ckeditor/ckeditor5/build/.manual-tests'
     
     ...
     
     [Webpack] Starting scripts compilation (non-DLL)...
     [Webpack] Finished the compilation (non-DLL).
     [Server] Server running at http://localhost:8125/
     [Webpack] Starting scripts compilation (non-DLL)...
     [Webpack] Finished the compilation (non-DLL).
    

    image

  • dll:build

     yarn run v1.22.19
     $ npm run build
     
     > ckeditor5@45.1.0 build
     > tsc --build --force ./tsconfig.release-ckeditor5.json
     
     npm notice
     npm notice New major version of npm available! 10.9.2 -> 11.4.0
     npm notice Changelog: https://github.com/npm/cli/releases/tag/v11.4.0
     npm notice To update run: npm install -g npm@11.4.0
     npm notice
     $ node scripts/dll/build-dlls.mjs --base-dll-config ./scripts/dll/webpack.config.dll.mjs
     Creating the base DLL build...
     Creating DLL-compatible package builds...
     Building ckeditor5-adapter-ckfinder...
     Building ckeditor5-alignment...
     Building ckeditor5-autoformat...
     ...
     ...
     ...
     Building ckeditor5-table...
     Building ckeditor5-word-count...
     Done in 87.38s.
    
  • Collab features dll - works.

@pomek pomek marked this pull request as ready for review May 20, 2025 12:35
@pomek
Copy link
Member Author

pomek commented May 21, 2025

The second round of testing:

  • yarn run changelog --branch master
    image
    image
  • yarn run release:prepare-packages --compile-only
    image
    image
  • yarn docs
    image

pomek and others added 7 commits May 21, 2025 13:34
…gherthancurrent.test.ts

Co-authored-by: Kamil Piechaczek <pomek@users.noreply.github.com>
…ailability.test.ts

Co-authored-by: Kamil Piechaczek <pomek@users.noreply.github.com>
…formonorepository.test.ts

Co-authored-by: Kamil Piechaczek <pomek@users.noreply.github.com>
…formonorepository.test.ts

Co-authored-by: Kamil Piechaczek <pomek@users.noreply.github.com>
…formonorepository.test.ts

Co-authored-by: Kamil Piechaczek <pomek@users.noreply.github.com>
martnpaneq and others added 4 commits May 22, 2025 11:18
…formonorepository.test.ts

Co-authored-by: Kamil Piechaczek <pomek@users.noreply.github.com>
Internal: Extracted external utils in `ckeditor5-dev-changelog` to separate files and fixed tests. See ckeditor/ckeditor5#18324.
@pomek pomek merged commit a216691 into epic/ck/18051-changeset May 22, 2025
3 checks passed
@pomek pomek deleted the ck/18324-changeset-dev-utils-typescript branch May 22, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cleanup utils/external in ckeditor5-dev-changelog.

4 participants