Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent of loading widgets if querrySelectorAll is undefiend #1320

Merged
merged 1 commit into from
Dec 4, 2017

Conversation

msamsel
Copy link
Contributor

@msamsel msamsel commented Dec 4, 2017

What is the purpose of this pull request?

Bug fix

This PR contains

  • Unit tests
  • Manual tests

What changes did you make?

  • prevent of running widget if querrySelectorAll is unavaialble

close #1319

Copy link
Member

@Comandeer Comandeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Comandeer Comandeer merged commit 230f715 into major Dec 4, 2017
@Comandeer Comandeer deleted the t/1319 branch December 4, 2017 14:06
@msamsel msamsel restored the t/1319 branch December 15, 2017 11:54
@msamsel msamsel deleted the t/1319 branch December 15, 2017 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt 4.8.0 to quirks mode
2 participants