You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
1 paths audited Performance: 94 (🟢 up 34 from production) Accessibility: 90 (no change from production) Best Practices: 92 (no change from production) SEO: 83 (no change from production) PWA: - View the detailed breakdown and full score reports
1 paths audited Performance: 14 (🟢 up 5 from production) Accessibility: 88 (no change from production) Best Practices: 92 (🔴 down 8 from production) SEO: 100 (no change from production) PWA: - View the detailed breakdown and full score reports
1 paths audited Performance: 75 (🟢 up 15 from production) Accessibility: 88 (no change from production) Best Practices: 92 (no change from production) SEO: 92 (no change from production) PWA: - View the detailed breakdown and full score reports
1 paths audited Performance: 71 (🔴 down 11 from production) Accessibility: 88 (no change from production) Best Practices: 92 (🔴 down 8 from production) SEO: 100 (no change from production) PWA: - View the detailed breakdown and full score reports
fghdotio
changed the title
feat(btc): add signPsbt/pushPsbt methods with UniSat and OKX implementations
feat(btc): add signPsbt/pushPsbt methods with UniSat,OKX and JoyID implementations
Jul 3, 2025
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully introduces signPsbt and pushPsbt methods across the Bitcoin signer implementations. The changes are well-documented with JSDoc comments, and the abstract methods are correctly implemented or stubbed out in concrete classes. The JoyID implementation's @remarks for pushPsbt is particularly helpful for understanding its combined functionality. The overall quality of the changes is high, with only minor stylistic improvements suggested for comment placement in the JoyID signer.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fghdotio
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
P2TR addresses are not supported yet.