-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add: gen 9 mini sprites #58
Conversation
Thanks for you awesome PR!!! I want to make sure that these sprites sources are allowed to be open source? If it's okay, I'll merge PR right away. |
i got the sprites from this resource pack right here: https://www.pokecommunity.com/threads/generation-9-resource-pack-v21-1.527398/ its meant to be a free thing for rom hack developers so i guess its okay? |
It looks fine. Can you help me add gen 9 sprites source link to the README? |
sure but these are fan made and aren't really available via any link unlike other poke sprites. they were originally like this and then i cut them in half like so currently, these are only available on my machine so should I upload them somewhere so they can be sourced? |
I see. I don't think it needs to be uploaded to somewhere. I'll just merge PR. Thank you for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hello again, I noticed this today so I thought I would let you know too. Please give them credit in the README. The roadmap would be a good place to do it I think. |
I've added the creator to the Readme. Thank you again. |
added gen 9 mini sprites and fixed some bugs like nidoran male and female sprites not showing up and also for flabebe's
Screenshots
i recently added the gen 9 mini sprites color scripts to the og phoney badger repo too:
https://gitlab.com/Fexxix/pokemon-colorscripts
i have created a PR for it too but he has been inactive for a long time