Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: gen 9 mini sprites #58

Merged
merged 1 commit into from
Sep 30, 2024
Merged

add: gen 9 mini sprites #58

merged 1 commit into from
Sep 30, 2024

Conversation

Fexxix
Copy link
Contributor

@Fexxix Fexxix commented Sep 29, 2024

added gen 9 mini sprites and fixed some bugs like nidoran male and female sprites not showing up and also for flabebe's

Screenshots

image
image
image

i recently added the gen 9 mini sprites color scripts to the og phoney badger repo too:
https://gitlab.com/Fexxix/pokemon-colorscripts

i have created a PR for it too but he has been inactive for a long time

@ckaznable
Copy link
Owner

ckaznable commented Sep 30, 2024

Thanks for you awesome PR!!!

I want to make sure that these sprites sources are allowed to be open source? If it's okay, I'll merge PR right away.

@Fexxix
Copy link
Contributor Author

Fexxix commented Sep 30, 2024

Thanks for you awesome PR!!!

I want to make sure that these sprites sources are allowed to be open source? If it's okay, I'll merge PR right away.

i got the sprites from this resource pack right here: https://www.pokecommunity.com/threads/generation-9-resource-pack-v21-1.527398/

its meant to be a free thing for rom hack developers so i guess its okay?

@ckaznable
Copy link
Owner

Thanks for you awesome PR!!!
I want to make sure that these sprites sources are allowed to be open source? If it's okay, I'll merge PR right away.

i got the sprites from this resource pack right here: https://www.pokecommunity.com/threads/generation-9-resource-pack-v21-1.527398/

its meant to be a free thing for rom hack developers so i guess its okay?

It looks fine. Can you help me add gen 9 sprites source link to the README?

@Fexxix
Copy link
Contributor Author

Fexxix commented Sep 30, 2024

Thanks for you awesome PR!!!
I want to make sure that these sprites sources are allowed to be open source? If it's okay, I'll merge PR right away.

i got the sprites from this resource pack right here: https://www.pokecommunity.com/threads/generation-9-resource-pack-v21-1.527398/
its meant to be a free thing for rom hack developers so i guess its okay?

It looks fine. Can you help me add gen 9 sprites source link to the README?

sure but these are fan made and aren't really available via any link unlike other poke sprites.

they were originally like this

image

and then i cut them in half like so

image

currently, these are only available on my machine so should I upload them somewhere so they can be sourced?

@ckaznable
Copy link
Owner

Thanks for you awesome PR!!!
I want to make sure that these sprites sources are allowed to be open source? If it's okay, I'll merge PR right away.

i got the sprites from this resource pack right here: https://www.pokecommunity.com/threads/generation-9-resource-pack-v21-1.527398/
its meant to be a free thing for rom hack developers so i guess its okay?

It looks fine. Can you help me add gen 9 sprites source link to the README?

sure but these are fan made and aren't really available via any link unlike other poke sprites.

they were originally like this

image

and then i cut them in half like so

image

currently, these are only available on my machine so should I upload them somewhere so they can be sourced?

I see. I don't think it needs to be uploaded to somewhere.

I'll just merge PR. Thank you for your contribution!

Copy link
Owner

@ckaznable ckaznable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ckaznable ckaznable merged commit 735578f into ckaznable:master Sep 30, 2024
@Fexxix
Copy link
Contributor Author

Fexxix commented Oct 19, 2024

LGTM

Hello again, I noticed this today so I thought I would let you know too. Please give them credit in the README. The roadmap would be a good place to do it I think.

image

@ckaznable
Copy link
Owner

Hello again, I noticed this today so I thought I would let you know too. Please give them credit in the README. The roadmap would be a good place to do it I think.

I've added the creator to the Readme. Thank you again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants