Skip to content

Fix Log File Not Working (Requires Bytes Mode) #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wardi merged 1 commit into from
Jan 16, 2026
Merged

Fix Log File Not Working (Requires Bytes Mode) #224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ckanapi/cli/batch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ def batch_actions(ckan, arguments,

log = None
if arguments['--log']:
log = open(arguments['--log'], 'a')
log = open(arguments['--log'], 'ab')

jsonl_input = stdin
if arguments['--input']:
Expand Down
2 changes: 1 addition & 1 deletion ckanapi/cli/delete.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def delete_things(ckan, thing, arguments,

log = None
if arguments['--log']:
log = open(arguments['--log'], 'a')
log = open(arguments['--log'], 'ab')

jsonl_input = stdin
if arguments['--input']:
Expand Down
2 changes: 1 addition & 1 deletion ckanapi/cli/dump.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def dump_things(ckan, thing, arguments,

log = None
if arguments['--log']:
log = open(arguments['--log'], 'a')
log = open(arguments['--log'], 'ab')

jsonl_output = stdout
if arguments['--datapackages']: # TODO: do we want to just divert this to devnull?
Expand Down
2 changes: 1 addition & 1 deletion ckanapi/cli/load.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def load_things(ckan, thing, arguments,

log = None
if arguments['--log']:
log = open(arguments['--log'], 'a')
log = open(arguments['--log'], 'ab')

jsonl_input = stdin
if arguments['--input']:
Expand Down