Skip to content

Commit

Permalink
remove container_name?
Browse files Browse the repository at this point in the history
For discussion: Removing the `container_name` lines lets us run many ckan-docker sites at the same time (assuming you use different ports)

What is the benefit in forcing a container name in the docker compose config?
  • Loading branch information
wardi authored Sep 26, 2023
1 parent 6bbc482 commit 2a8f844
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions docker-compose.dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ volumes:
services:

ckan-dev:
container_name: ${CKAN_CONTAINER_NAME}
build:
context: ckan/
dockerfile: Dockerfile.dev
Expand All @@ -33,14 +32,12 @@ services:
test: ["CMD", "wget", "-qO", "/dev/null", "http://localhost:5000"]

datapusher:
container_name: ${DATAPUSHER_CONTAINER_NAME}
image: ckan/ckan-base-datapusher:${DATAPUSHER_VERSION}
restart: unless-stopped
healthcheck:
test: ["CMD", "wget", "-qO", "/dev/null", "http://localhost:8800"]

db:
container_name: ${POSTGRESQL_CONTAINER_NAME}
build:
context: postgresql/
environment:
Expand All @@ -60,7 +57,6 @@ services:
test: ["CMD", "pg_isready", "-U", "${POSTGRES_USER}", "-d", "${POSTGRES_DB}"]

solr:
container_name: ${SOLR_CONTAINER_NAME}
image: ckan/ckan-solr:${SOLR_IMAGE_VERSION}
volumes:
- solr_data:/var/solr
Expand All @@ -69,8 +65,7 @@ services:
test: ["CMD", "wget", "-qO", "/dev/null", "http://localhost:8983/solr/"]

redis:
container_name: ${REDIS_CONTAINER_NAME}
image: redis:${REDIS_VERSION}
restart: unless-stopped
healthcheck:
test: ["CMD", "redis-cli", "-e", "QUIT"]
test: ["CMD", "redis-cli", "-e", "QUIT"]

0 comments on commit 2a8f844

Please sign in to comment.