Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PEP 517 and 518 #1

Merged
merged 4 commits into from
Aug 22, 2019
Merged

Support PEP 517 and 518 #1

merged 4 commits into from
Aug 22, 2019

Conversation

cjolowicz
Copy link
Owner

No description provided.

@cjolowicz
Copy link
Owner Author

cjolowicz commented Aug 21, 2019

CI failed with this error:

$ bundle exec hatchet ci:setup
/home/travis/build/cjolowicz/heroku-buildpack-python/vendor/bundle/ruby/2.4.0/gems/heroku_hatchet-4.0.6/etc/ci_setup.rb:10:
in `fetch': key not found: "HEROKU_API_USER" (KeyError)

It appears we first need to configure Travis for Heroku access: #2

@cjolowicz cjolowicz force-pushed the support-pep-517-and-518 branch 2 times, most recently from a6c6660 to 886d000 Compare August 21, 2019 19:51
@cjolowicz
Copy link
Owner Author

CI failed because some tests didn't pass:

testPoetry

pip refuses to perform an editable install for a pyproject.toml-based project.

testPoetry
ASSERT:Captured exit code - expected:<0> but was:<1>
-----> Installing python-3.6.8
-----> Installing pip
-----> Installing SQLite3
-----> Installing requirements with pip
       ERROR: File "setup.py" not found. Directory cannot be installed in editable mode: /tmp/testJLs6T
       (A "pyproject.toml" file was found, but editable mode currently requires a setup.py based build.)

testPoetryLock

Same as above.

testPoetryLock
ASSERT:Captured exit code - expected:<0> but was:<1>
-----> Installing python-3.6.8
-----> Installing pip
-----> Installing SQLite3
-----> Installing requirements with pip
       ERROR: File "setup.py" not found. Directory cannot be installed in editable mode: /tmp/testvjOhS
       (A "pyproject.toml" file was found, but editable mode currently requires a setup.py based build.)

testSmartRequirements

This is a regression, possibly caused by the pip upgrade. Apparently obsolete requirements are not uninstalled correctly.

testSmartRequirements
ASSERT:Expected </tmp/shunit.nlRHuC/tmp/output.nU2q/stdout> to contain <Uninstalling requests>
-----> Installing requirements with pip
       Collecting psycopg2 (from -r /tmp/testHoJ9o/requirements.txt (line 1))
         Downloading https://files.pythonhosted.org/packages/5c/1c/6997288da181277a0c29bc39a5f9143ff20b8c99f2a7d059cfb55163e165/psycopg2-2.8.3.tar.gz (377kB)
       Building wheels for collected packages: psycopg2
         Building wheel for psycopg2 (setup.py): started
         Building wheel for psycopg2 (setup.py): finished with status 'done'
         Created wheel for psycopg2: filename=psycopg2-2.8.3-cp36-cp36m-linux_x86_64.whl size=445840 sha256=09486d748c43fc8bc6af2f363fc274314c5faf9adfdbf4a172f4b5cff00650d7
         Stored in directory: /tmp/pip-ephem-wheel-cache-pbj7gvfl/wheels/48/06/67/475967017d99b988421b87bf7ee5fad0dad789dc349561786b
       Successfully built psycopg2
       Installing collected packages: psycopg2
       Successfully installed psycopg2-2.8.3

@cjolowicz
Copy link
Owner Author

Editable install and pyproject.toml

Related issues and PRs:

PR Issue
pypa/pip#6331 pypa/pip#6314
pypa/pip#6370 pypa/pip#6375
- python-poetry/poetry#826

@cjolowicz cjolowicz force-pushed the support-pep-517-and-518 branch 10 times, most recently from c854946 to e70bd25 Compare August 22, 2019 18:48
Add two test cases for projects using poetry as the build backend:

- testPoetry: project without dependencies

- testPoetryLock: project with dependencies, using a poetry.lock file
Add two test cases for projects using flit as the build backend:

- testFlit: project without dependencies

- testFlitRequires: project with dependencies
@cjolowicz cjolowicz merged this pull request into master Aug 22, 2019
@cjolowicz cjolowicz deleted the support-pep-517-and-518 branch August 22, 2019 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant