Fix logging bug

Error logged everytime an assignee was removed
cjkoenig · Feb 12, 2017 · 076f940 · 076f940
1 parent d76f34e
commit 076f940
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/models/issue.go b/models/issue.go
@@ -775,14 +775,12 @@ func (issue *Issue) ChangeAssignee(doer *User, assigneeID int64) (err error) {
 		} else {
 			apiPullRequest.Action = api.HookIssueAssigned
 		}
-		err = PrepareWebhooks(issue.Repo, HookEventPullRequest, apiPullRequest)
-	}
-	if err != nil {
-		log.Error(4, "PrepareWebhooks [is_pull: %v, remove_assignee: %v]: %v", issue.IsPull, isRemoveAssignee, err)
-	} else {
-		go HookQueue.Add(issue.RepoID)
+		if err := PrepareWebhooks(issue.Repo, HookEventPullRequest, apiPullRequest); err != nil {
+			log.Error(4, "PrepareWebhooks [is_pull: %v, remove_assignee: %v]: %v", issue.IsPull, isRemoveAssignee, err)
+			return nil
+		}
 	}
-
+	go HookQueue.Add(issue.RepoID)
 	return nil
 }