forked from linuxserver/docker-code-server
-
Notifications
You must be signed in to change notification settings - Fork 0
[CIVIS-11019] update to use ubuntu 22.04 fips enabled base image #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+158
−2,076
Merged
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
3bfd17e
ubuntu fips
thatguyinabeanie 50c10eb
Improve Dockerfile formatting and readability
thatguyinabeanie 0bb283b
remove extraneous file
thatguyinabeanie 414f1f2
remove jenkins things
thatguyinabeanie 0bebddb
remove extra files
thatguyinabeanie b32f1c3
Add docker-compose configuration for FIPS-compliant code-server
thatguyinabeanie 8915795
simplify
thatguyinabeanie 6c23c47
update image
thatguyinabeanie 1ca26ee
update image
thatguyinabeanie 40f5049
update image
thatguyinabeanie fe03100
add netcat-openbsd
thatguyinabeanie 7637e2a
netcat
thatguyinabeanie e830bde
default ids 0
thatguyinabeanie 11c069f
remove extra files
thatguyinabeanie fd18ecd
remove more workflows
thatguyinabeanie d357271
upgrade Python to 3.12
thatguyinabeanie 6bb89ae
add buildspec
thatguyinabeanie cb13d90
update buildspec defs
thatguyinabeanie ca52326
update buildspec defs
thatguyinabeanie 2b6f4a0
ubuntu-fips-2
thatguyinabeanie 8e10bb3
fixed buildspec args
thatguyinabeanie fb27f43
FIPS_REPOSITORY_URI
thatguyinabeanie addee7a
styling
thatguyinabeanie c5a7d28
update placeholders
thatguyinabeanie 2173f99
latest
thatguyinabeanie 68107d3
latest
thatguyinabeanie 4395614
put that thing back where it came from or so help me
thatguyinabeanie 776f939
only need 1
thatguyinabeanie d6a9560
simplify Dockerfile
thatguyinabeanie 97b8760
no need ignores
thatguyinabeanie 26a1236
no need ignores
thatguyinabeanie d8e33b5
simplify
thatguyinabeanie cae16a0
remove comment
thatguyinabeanie 6a86840
trigger codebuild
thatguyinabeanie c3d1d0e
jammy
thatguyinabeanie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,43 +1,38 @@ | ||
| <!--- Provide a general summary of your changes in the Title above --> | ||
| ## Description | ||
|
|
||
| [linuxserverurl]: https://linuxserver.io | ||
| [][linuxserverurl] | ||
| Required: Please provide a brief description of what this pull request is trying to accomplish. | ||
|
|
||
| > | ||
|
|
||
| <!--- Before submitting a pull request please check the following --> | ||
| ## Context, Consequences, & Considerations | ||
|
|
||
| <!--- If this is a fix for a typo (in code, documentation, or the README) please file an issue and let us sort it out. We do not need a PR --> | ||
| <!--- Ask yourself if this modification is something the whole userbase will benefit from, if this is a specific change for corner case functionality or plugins please look at making a Docker Mod or local script https://blog.linuxserver.io/2019/09/14/customizing-our-containers/ --> | ||
| <!--- That if the PR is addressing an existing issue include, closes #<issue number> , in the body of the PR commit message --> | ||
| <!--- You have included links to any files / patches etc your PR may be using in the body of the PR commit message --> | ||
| <!--- We maintain a changelog of major revisions to the container at the end of readme-vars.yml in the root of this repository, please add your changes there if appropriate --> | ||
| Required: Please step through the following list, pausing at each item to consider your change in relation to the item's context. | ||
| Check the box to mark that it applies, and enter your relevant notes under the item. | ||
|
|
||
| - [ ] Security: This has security implications. This includes (but not limited to) adding users, modifying user/app permissions, network rules/policies, changing a system interconnection, or changing an authorization strategy. | ||
| - [ ] This PR does not require security review. These changes are part of a project plan that has already undergone security review. The link is provided below. | ||
| - [ ] This PR requires security review. Add the `security` label to this PR then request a review from the [Security Code Reviewers Team](https://github.com/orgs/civisanalytics/teams/security-code-reviewers). | ||
|
|
||
| <!--- Coding guidelines: --> | ||
| <!--- 1. Installed packages in the Dockerfiles should be in alphabetical order --> | ||
| <!--- 2. Changes to Dockerfile should be replicated in Dockerfile.armhf and Dockerfile.aarch64 if applicable --> | ||
| <!--- 3. Indentation style (tabs vs 4 spaces vs 1 space) should match the rest of the document --> | ||
| <!--- 4. Readme is auto generated from readme-vars.yml, make your changes there --> | ||
| > | ||
|
|
||
| ------------------------------ | ||
| - [ ] Execution: This change requires commands to be run outside of the normal merge. | ||
|
|
||
| - [ ] I have read the [contributing](https://github.com/linuxserver/docker-code-server/blob/master/.github/CONTRIBUTING.md) guideline and understand that I have made the correct modifications | ||
| > | ||
|
|
||
| ------------------------------ | ||
| - [ ] Impact: This change may cause service interruptions. | ||
|
|
||
| <!--- We welcome all PR’s though this doesn’t guarantee it will be accepted. --> | ||
| > | ||
|
|
||
| ## Description: | ||
| <!--- Describe your changes in detail --> | ||
| - [ ] Testing: How did you test this change (unit tests, acceptance tests, etc.)? Did you do any manual testing? | ||
|
|
||
| ## Benefits of this PR and context: | ||
| <!--- Please explain why we should accept this PR. If this fixes an outstanding bug, please reference the issue # --> | ||
| > | ||
|
|
||
| ## How Has This Been Tested? | ||
| <!--- Please describe in detail how you tested your changes. --> | ||
| <!--- Include details of your testing environment, and the tests you ran to --> | ||
| <!--- see how your change affects other areas of the code, etc. --> | ||
| - [ ] Testing: How will you confirm this change once it's merged? | ||
|
|
||
| > | ||
|
|
||
| ## Source / References: | ||
| <!--- Please include any forum posts/github links relevant to the PR --> | ||
| - [ ] Documentation: Documentation to reflect this change has been added to Confluence or Zendesk. | ||
|
|
||
| > | ||
|
|
||
| - [ ] **All items of the checklist have been considered and this PR description is complete.** |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's this bit doing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so ubuntu 22 doesnt know where to install python 3.12 from. this tells apt-get where to install python 3.12 from
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love that python lives in deadsnakes 😆