Skip to content

Conversation

@elsander
Copy link
Contributor

This PR updates dependencies for version 6 of datascience-python.

Tagging @jacksonllee to confirm that no changes interfere with CivisML dependencies (I think pyarrow is the only one that overrides your previous updates?)

@elsander
Copy link
Contributor Author

@channiemills I'm not sure why the circle tests are showing as pending. When you click through, it shows that the tests succeeded. This should be ready for review.

@channiemills
Copy link

Just want to confirm, does the Dockerfile need updating for the new civis conda and civis python versions? I saw they were updated in the last DEP release PR.

@channiemills
Copy link

Ah, nevermind I see they must have been updated in a previous PR, just not in this diff.

Copy link

@channiemills channiemills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jacksonllee jacksonllee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with respect to CivisML -- I confirm that all package versions here are compatible with the next CivisML release.

@elsander elsander merged commit 0f55b33 into master Feb 17, 2020
@civis-robot
Copy link

Pull Request Merged!!! This build is running now.

@elsander elsander deleted the SERD-1717-dependency-bump branch February 17, 2020 19:59
mheilman pushed a commit to mheilman/datascience-python that referenced this pull request Sep 30, 2020
* SERD-1717 MAINT dependency bump

* MAINT update civis and changelog

Co-authored-by: Nick Lee <nicholas.lee.3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants