Skip to content

Conversation

@keithing
Copy link
Contributor

@keithing keithing commented May 3, 2018

This add instructions for adding the environmental variable CIVIS_API_KEY in Windows.

@keithing keithing requested a review from stephen-hoover May 3, 2018 15:25
Copy link

@stephen-hoover stephen-hoover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this documentation! This is helpful. Apart from inline suggestions, you should also add a note in the changelog.

README.rst Outdated
5. Install the package::
2. Source your ``.bash_profile`` (or restart your terminal).

Windows

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this applies to Windows 10 and possibly Windows 7. Is XP the same?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, I've only looked at Windows 10. I'm going to tag this as Windows 10 so it's clear, but I don't want to hold up this PR because it might take some time to track down Windows 7 and XP boxes.

README.rst Outdated
1. Navigate to ``Settings`` -> type "environment" in search bar ->
``Edit environment variables for your account``. This can also be found
in ``System Properties`` -> ``Advanced`` -> ``Environment Variables...``.
2. If ``CIVIS_API_KEY`` already exists in the list of environment variables,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there are two lists of environment variables, "User variables" and "System variables", yes? I think we should tell users to add their API key to the user variables.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I'll add a note.

client = civis.APIClient()
print(client.users.list_me()['username'])
If ``civis-python`` was installed correctly, this will print your Civis

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Civis" -> "Civis Platform"

README.rst Outdated
API Keys
--------

Usage of ``civis-python`` requires a valid Civis API key, which can be created

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Civis API key" -> "Civis Platform API key"?

@keithing keithing assigned stephen-hoover and unassigned keithing May 3, 2018
Copy link

@stephen-hoover stephen-hoover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

5. Install the package::
2. Source your ``.bash_profile`` (or restart your terminal).

Windows 10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth mentioning https://docs.microsoft.com/en-us/windows/wsl/install-win10, which in my opinion is the best way to use python in windows.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect users will already have a workflow for python on Windows before they install civis. This is pretty cool, though.

@keithing keithing merged commit b934b76 into civisanalytics:master May 3, 2018
@keithing keithing deleted the windows-api-key branch May 3, 2018 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants