Update DB_Object #280
Merged
Update DB_Object #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4476 (also txt from svn days): Extend CaseType API to return/save XML This appears to be tested although reading the code it seems like it should not be required. Used in case Types m
|
(Standard links)
|
seamuslee001
reviewed
Jan 3, 2020
DB/common.php
Outdated
| @@ -1161,6 +1161,16 @@ function modifyQuery($query) | |||
| $e = new \Civi\Core\Event\QueryEvent($query); | |||
| Civi::$statics['db_common_dispatcher']->dispatch('civi.db.query', $e); | |||
| return $e->query; | |||
|
|
|||
There was a problem hiding this comment.
@eileenmcnaughton i believe that this was an earlier version of what is in the lines above
There was a problem hiding this comment.
seamuslee001
reviewed
Jan 3, 2020
DB/common.php
Outdated
| @@ -2264,6 +2274,9 @@ function _convertNullArrayValuesToEmpty(&$array) | |||
| } | |||
| } | |||
|
|
|||
| function lastInsertId() { | |||
There was a problem hiding this comment.
I believe this is a duplicate of L2288 (a modification of the patch included in #276
eileenmcnaughton
force-pushed
the
master
branch
from
15d0cdf to
253242d
Compare
…n CIVICRM_DEBUG_LOG_QUERY is on CRM-18093 extend query time logging with string for grepping CRM-18093 More query debug info and a separate log file
…adlock is met. This is restoring previous functionality broken when we meddled with deadlocks. Improve deadlock error handling m
…r PHP 7.3 PHP 7.3 has started to issue warnings when a continue statement is inside a switch and interpreted as a break "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? In this case, the switch statement was weird anyway, so I've replaced it with a couple of if statements to do the same thing.
…ts to utf8mb4 if we're using MySQL 5.5.3+
eileenmcnaughton
force-pushed
the
master
branch
from
253242d to
80c1c0c
Compare
…ve problems on date, timestamp fields
CRM-16431
Fix DAO failure to save to timestamp fields
CRM-20178 do not skip timestamps
x
m
eileenmcnaughton
force-pushed
the
master
branch
from
80c1c0c to
0e0f173
Compare
|
I'm going to treat this as a reviewers cut so merging |
|
@seamuslee001 yes I'm happy with that - it was a bit of a slog to do but we both reached the same conclusion so yay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.