Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new consolidated constant for minimum PHP version #599

Merged
merged 2 commits into from
Mar 13, 2020

Conversation

agh1
Copy link
Contributor

@agh1 agh1 commented Mar 11, 2020

@civibot
Copy link

civibot bot commented Mar 11, 2020

(Standard links)

@agh1
Copy link
Contributor Author

agh1 commented Mar 12, 2020

The regex was looking for x.y.z, and source data is x.y only. I updated it to ignore the point release unless it's non-zero.

@agh1 agh1 force-pushed the single-php-version branch from 7d71cdc to 87eab44 Compare March 12, 2020 01:10
@totten
Copy link
Member

totten commented Mar 13, 2020

Looks good. 👍 Change makes sense. Tests pass. I did an r-run on php70 and php71 with drush (drush ev 'civicrm_initialize(); echo "hi\n";'), and (on php70) it complained correctly.

@totten totten merged commit 2567ae2 into civicrm:7.x-master Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants