(NFC) Civi/*, CRM_Utils_SQL_Select - Fix various warnings #9657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -36,6 +36,7 @@ public static function onCaseChange_static(\Civi\CCase\Event\CaseChangeEvent $ev | |||
| * @param \Civi\CCase\Event\CaseChangeEvent $event | |||
| * | |||
| * @throws \CiviCRM_API3_Exception | |||
| * @return void | |||
There was a problem hiding this comment.
I think this is not part of the drupal std
There was a problem hiding this comment.
Yeah, I'm not attached to that. No sweat off my back if it's removed. I only really care about writing code that passes civicrm/coder. ;)
FWIW, this seems like a conflict between some standard (e.g. drupal/coder vs PHPStorm or civicrm/coder?) My PHPStorm insisted on having a @return annotation because the function includes return; statements.
|
I'm giving this merge-on-pass. I think the void is wrong - but I think it can be fixed in a later round when applying more standards & prefer to get this merged while it's not stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.