[ready-for-core-team-review]CRM-19799, fixed contribution params to include line items #9580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradpnayak
force-pushed
the
CRM-19799
branch
2 times, most recently
from
fa14e99 to
508db8e
Compare
pradpnayak
changed the title
jitendrapurohit
approved these changes
Dec 27, 2016
There was a problem hiding this comment.
Tested and confirmed that it fixes the line_item for priceset contributions stated in the issue. Just pinging @eileenmcnaughton if she's fine with the changes.
|
Yay for the test! I feel that we should be trying to push the elicitation of the line items back to the form layer. I believe the way in which the form object is passed around with variables somewhat randomly snatched from it is confusing. So, I would prefer to see $paymentParams['line_item'] passed in - which would trigger |
---------------------------------------- * CRM-19799: LineItems incorrect at both Contribution Level and Financial Accounts Level https://issues.civicrm.org/jira/browse/CRM-19799
---------------------------------------- * CRM-19799: LineItems incorrect at both Contribution Level and Financial Accounts Level https://issues.civicrm.org/jira/browse/CRM-19799
---------------------------------------- * CRM-19799: LineItems incorrect at both Contribution Level and Financial Accounts Level https://issues.civicrm.org/jira/browse/CRM-19799
pradpnayak
force-pushed
the
CRM-19799
branch
from
508db8e to
1659de2
Compare
|
@eileenmcnaughton @jitendrapurohit @monishdeb |
jitendrapurohit
approved these changes
Dec 29, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.civicrm.org/jira/browse/CRM-19799