Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Afform - Add maxlength validation and character count #31668

Merged
merged 1 commit into from
Jan 1, 2025

Conversation

colemanw
Copy link
Member

Overview

Configurable max length for fields is enforced, and for text areas a live counter is shown below.

image

See https://lab.civicrm.org/dev/core/-/issues/5649

Copy link

civibot bot commented Dec 31, 2024

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Dec 31, 2024
@monishdeb
Copy link
Member

Tested, looks good.

@monishdeb monishdeb merged commit eae8c55 into civicrm:master Jan 1, 2025
1 check passed
@colemanw colemanw deleted the afformMaxLength branch January 1, 2025 16:23
@danielstrum
Copy link

@colemanw I just tested this and it seems great. Thanks and let me know next steps.

@colemanw
Copy link
Member Author

colemanw commented Jan 6, 2025

@danielstrum we're all set on the code-side of things, the PR has been merged so will go into the new beta on Wednesday of this week, and then be part of next month's release.
You should have received an invoice for the work from Josh. Let me know if you didn't get that.

@danielstrum
Copy link

Hi @colemanw

Yes, I tested this on our dev site and it seems great. Thank so much. Please send the invoice to my work address, daniel@ajmuste.org

@danielstrum
Copy link

danielstrum commented Jan 7, 2025

@colemanw, there is an issue... If a form has a existing contact field that can create a new contact, if the user tries to create a new contact, they get the error "Please enter no more than 0 characters."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants