ActionObjectProvider - roll back mismatched entity error

[ufundo]

Overview

Fix for https://lab.civicrm.org/dev/core/-/issues/5533

Before

• throw an error when trying to take an action on an entity we dont recognise
• making api calls for entities that dont exist (yet) always throw an error
• calling an api provided by an extension in that extension's own installer crashes

After

• dont throw the error
• some api actions will still work, even when the entity doesn't exist yet
• others will fail in diverse ways (e.g. getting DAOEntities gives a cryptic mysql error)
• others might not definitely fail, but could behave unexpected ways?

Comments

It doesn't feel great to me to allow this, as I think it might cause some strange bugs. But it is the pre-existing behaviour.

Maybe going forward we could add a flag on a given API action class that allows you to bypass this check. Then in @eileenmcnaughton 's example, the required WMFConfig 's could opt out of the check. But in general we'll catch weird edge cases before they become a problem.

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[ufundo]

Adding run-standalone to check the original regression in the upgrader doesn't regress again.