Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require both first and last name when creating contact #31289

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mattwire
Copy link
Contributor

Overview

Remove unnecessary form layer restriction that forces an individual to have a first and last name.

You can create individuals with only first or last name via the API so this just removes the restriction from the "Edit Individual" UI.

Before

Error if you try to create a contact with only firstname.

After

Allowed

Technical Details

Comments

Copy link

civibot bot commented Oct 13, 2024

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Oct 13, 2024
@mattwire mattwire changed the title Allow only first or last name when creating contact Allow to only enter first or last name when creating contact Oct 13, 2024
@mattwire mattwire changed the title Allow to only enter first or last name when creating contact Don't require both first and last name when creating contact Oct 13, 2024
@kcristiano
Copy link
Member

@mattwire is there a lab issue for this for greater visibility? Is there a particular problem this PR tries to solve?

I can see an argument to have API to enforce the business rule as opposed to making this change.

I can see a good number of contacts created in error and work for staff on deduping and cleanup.

Not against this per se, but I do think this would be good to have a discussion on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants