Participant Import: avoid listing custom fields twice #31181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷 Introduction for new contributors...
Quick links for reviewers...
|
mlutfy
reviewed
Oct 16, 2024
| @@ -273,7 +273,10 @@ protected function getContactFields(string $contactType): array { | |||
| */ | |||
| protected function getImportFieldsForEntity(string $entity): array { | |||
| return (array) civicrm_api4($entity, 'getFields', [ | |||
| 'where' => [['usage', 'CONTAINS', 'import']], | |||
| 'where' => [ | |||
There was a problem hiding this comment.
@jmcclelland I'm not too familiar with this code - could you add a comment to explain the where? I feel like if this behaviour changes at some point in the future and custom fields are missing during import, someone will be very confused about why the condition is that way.
mlutfy
changed the title
mlutfy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Custom fields are listed twice on the mapping screen when importing participants
Before
If you create a custom participant field (used for Participants - ANY). Then, click Events -> Import Participants. Add a csv file and go to the Mapping page. You will see that custom fields are listed twice:
After
They are only listed once.
Technical Details
@eileenmcnaughton I think this is a regression from c56953d.