Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony update 5.4.43 (from recent update to 5.4.42 but now .43 is out) #31034

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

We just updated to 5.4.42 but 3 days ago symfony put out 5.4.43 - seems silly to upgrade but not to the one that is the latest when we tag

Before

just updated to 5.4.42

After

composer update -W symfony/*
Gathering patches for root package.
Loading composer repositories with package information Updating dependencies
Lock file operations: 0 installs, 3 updates, 0 removals

  • Upgrading symfony/dependency-injection (v5.4.42 => v5.4.43)
  • Upgrading symfony/finder (v5.4.42 => v5.4.43)
  • Upgrading symfony/var-dumper (v5.4.42 => v5.4.43)

Technical Details

The key PR is
symfony/symfony#57493

And I note that it seems like a sleeper bug depending on server config- ie

symfony/symfony#57493 (comment) "Ubuntu will join impacted systems on October 10 when 24.10 is released." The final summary says there are no deprecations but this comment
symfony/symfony#57493 (comment) suggests there might be

I don't really know if we have security bundles but it seems like this fixes a bug that occurs when libxml libraries are used but it adds a deprecation. Also our composer-installing instances will be getting this fix so it will be less confusing to patch the tarball

Comments

We just updated to 5.4.42 but 3 days ago symfony put out 5.4.43 - seems silly
to upgrade but not to the one that is the latest when we tag

The key PR is
symfony/symfony#57493

And I note that it seems like a sleeper bug depending on server config- ie

symfony/symfony#57493 (comment)
"Ubuntu will join impacted systems on October 10 when 24.10 is released."
The final summary says there are no deprecations but this
comment
symfony/symfony#57493 (comment)
suggests there might be

I don't really know if we have security bundles but it seems like
this fixes a bug that occurs when libxml libraries are used but
it adds a deprecation. Also our composer-installing instances will be
getting this fix so it will be less confusing to patch the tarball

composer update -W symfony/*
Gathering patches for root package.
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 3 updates, 0 removals
  - Upgrading symfony/dependency-injection (v5.4.42 => v5.4.43)
  - Upgrading symfony/finder (v5.4.42 => v5.4.43)
  - Upgrading symfony/var-dumper (v5.4.42 => v5.4.43)
Copy link

civibot bot commented Sep 2, 2024

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Sep 2, 2024
@seamuslee001 seamuslee001 merged commit 4e84d6b into civicrm:master Sep 2, 2024
1 check passed
@seamuslee001 seamuslee001 deleted the composer branch September 2, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants